Add cftime support for non-standard calendars by cvanelteren · Pull Request #344 · Ultraplot/UltraPlot

cvanelteren · 2025-09-10T10:12:24Z

This PR introduces support for plotting data with non-standard calendars using cftime.

Key changes:

Added CFTimeConverter to enable matplotlib to handle cftime.datetime objects.
Implemented AutoDatetimeLocator and AutoDatetimeFormatter for automatic, "nice" tick generation on cftime axes, mimicking matplotlib's behavior for standard datetime objects.
Added a regression test using pytest-mpl to ensure visual consistency of plots with non-standard calendars.

This resolves issues where plots with non-standard calendars had incorrect or poorly formatted time axes.

Continuation of #289

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

codecov · 2025-09-10T10:26:11Z

Codecov Report

❌ Patch coverage is 77.13816% with 139 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
ultraplot/ticker.py	66.98%	63 Missing and 41 partials ⚠️
ultraplot/tests/test_tickers.py	89.92%	20 Missing and 8 partials ⚠️
ultraplot/internals/rcsetup.py	53.33%	4 Missing and 3 partials ⚠️

📢 Thoughts on this report? Let us know!

cvanelteren · 2025-09-10T10:37:17Z

~~Still fixing one test but rest should be ready for review.~~

cvanelteren · 2025-09-11T07:56:44Z

We may want to style the formatting further. In particular this

_RESOLUTION_TO_FORMAT = {
    "SECONDLY": "%H:%M:%S",
    "MINUTELY": "%H:%M",
    "HOURLY": "%Y-%m-%d %H:%M",
    "DAILY": "%Y-%m-%d",
    "MONTHLY": "%Y-%m",
    "YEARLY": "%Y",
}

cvanelteren · 2025-09-11T09:31:15Z

Got the coverage to 65 percent from 0. Little bit done with adding tests and this should be good enough for now.

ultraplot/ticker.py

Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com>

ultraplot/ticker.py

Copilot

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

ultraplot/ticker.py

ultraplot/tests/test_tickers.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

beckermr

One more question. Looking good!

ultraplot/ticker.py

cvanelteren · 2025-10-03T17:41:21Z

Maybe I will add a bit more tests in the next few days but otherwise this is good to go.

cvanelteren · 2025-10-05T10:52:26Z

Autoformatting prefix and suffix are bugged. Will do this in another PR. I think the coverage is now 78% which is good enough for now. Will wait for codecov confirmation

cvanelteren added 2 commits September 10, 2025 12:07

add cftime formatter

6de2f78

add unittest

3b67756

cvanelteren mentioned this pull request Sep 10, 2025

Add error when plotting cftime #289

Closed

cvanelteren requested a review from Copilot September 10, 2025 10:13

This comment was marked as resolved.

Sign in to view

cvanelteren and others added 3 commits September 10, 2025 12:16

add converter and register units

27e4e8e

Apply suggestion from @Copilot

6f0f547

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

add cftime dep

fb16610

cvanelteren added 2 commits September 10, 2025 12:32

add more unittests

95e0bc3

fix some tests

0902895

cvanelteren requested a review from beckermr September 10, 2025 10:35

rm debug

489b0f0

cvanelteren added 2 commits September 10, 2025 13:21

add more points

c164b28

revert regex

dda122a

cvanelteren force-pushed the feat-add-no-greg-timeformatting branch from bd5c2df to dda122a Compare September 10, 2025 11:46

fix resolution

f03f94c

cvanelteren requested a review from Copilot September 11, 2025 07:59

This comment was marked as resolved.

Sign in to view

add more tests and redo resolution computation

febd860

cvanelteren force-pushed the feat-add-no-greg-timeformatting branch from d996c73 to febd860 Compare September 11, 2025 08:05

fix f strings

2621564

cvanelteren added this to the v1.65.0 milestone Sep 11, 2025

add more tests for coverage

9e76c41

cvanelteren force-pushed the feat-add-no-greg-timeformatting branch from 41e6350 to 9e76c41 Compare September 11, 2025 09:30

beckermr reviewed Sep 11, 2025

View reviewed changes

ultraplot/ticker.py Outdated Show resolved Hide resolved

ultraplot/ticker.py Outdated Show resolved Hide resolved

ultraplot/ticker.py Outdated Show resolved Hide resolved

ultraplot/ticker.py Outdated Show resolved Hide resolved

Update ultraplot/ticker.py

4376869

Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com>

cvanelteren added 3 commits September 29, 2025 18:14

fix typo

6d3bcd8

remove debug

2995c62

remove try block in test

8e050ab

pgf reviewed Sep 29, 2025

View reviewed changes

ultraplot/ticker.py Outdated Show resolved Hide resolved

beckermr and others added 6 commits September 29, 2025 14:47

Merge branch 'main' into feat-add-no-greg-timeformatting

405ab10

get calendars from private var

9bbb8dc

rm type info from default data range

2af6751

simplify type registry

3daf445

Replace datetime specific objects with general datetime

e072d8d

More replacements

46dcf71

cvanelteren requested review from beckermr and Copilot September 30, 2025 16:54

Copilot AI reviewed Sep 30, 2025

View reviewed changes

ultraplot/ticker.py Outdated Show resolved Hide resolved

ultraplot/ticker.py Outdated Show resolved Hide resolved

ultraplot/tests/test_tickers.py Show resolved Hide resolved

ultraplot/tests/test_tickers.py Outdated Show resolved Hide resolved

cvanelteren and others added 2 commits September 30, 2025 18:56

Update ultraplot/tests/test_tickers.py

0575585

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update ultraplot/ticker.py

6dcd213

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

beckermr requested changes Oct 3, 2025

View reviewed changes

ultraplot/ticker.py Outdated Show resolved Hide resolved

cvanelteren added 4 commits October 3, 2025 19:38

rm resolution format in ticker

b0b5d4f

make standard a bit less extreme

16ed4c0

make standard a bit less extreme

c9de5c3

Merge branch 'main' into feat-add-no-greg-timeformatting

ef8a4d3

beckermr approved these changes Oct 3, 2025

View reviewed changes

cvanelteren added 2 commits October 3, 2025 19:44

rm dead comment

8acfdd0

more tests

cbbf538

refactor tests

d7a74d8

cvanelteren mentioned this pull request Oct 5, 2025

Autoformatting ignores number when adding prefix and suffix #359

Closed

cvanelteren merged commit 08a6b2b into Ultraplot:main Oct 5, 2025
24 of 25 checks passed

cvanelteren deleted the feat-add-no-greg-timeformatting branch October 5, 2025 11:21

cvanelteren mentioned this pull request Oct 5, 2025

Add unittests for AutoFormatting #360

Merged

Conversation

cvanelteren commented Sep 10, 2025

Uh oh!

This comment was marked as resolved.

Uh oh!

codecov bot commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

cvanelteren commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cvanelteren commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

cvanelteren commented Sep 11, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

beckermr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cvanelteren commented Oct 3, 2025

Uh oh!

cvanelteren commented Oct 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Sep 10, 2025 •

edited

Loading

cvanelteren commented Sep 10, 2025 •

edited

Loading

cvanelteren commented Sep 11, 2025 •

edited

Loading

cvanelteren commented Oct 5, 2025 •

edited

Loading